Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

People definitely misuse PRs though, and while it's common for engineers to go "well that's their problem, I'M logically correct!", I think that's the wrong approach.

One very common thing that I've seen is opening a PR just to double-check the way the PR looks on github. Ideally they mark these PRs with "WIP" either in the title or as a tag. It's implied that those PRs aren't ready for review.

If you weren't expecting critiques of your code while you were in the middle of developing it (perhaps you have placeholder code all over the place), it could be jarring and distracting.

This goes against the purpose of PRs, but at some point you have to put engineering culture flexibility above strict letter-of-the-law guidelines.

If someone didn't pick up on this phenomenon, I'd gently inform them. There would be no need for getting upset... unless they continued doing it in spite of the commonly agreed-upon behavior of the team.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: